Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: landing page broken on small screen #1592

Merged
merged 3 commits into from
Aug 12, 2024
Merged

fix: landing page broken on small screen #1592

merged 3 commits into from
Aug 12, 2024

Conversation

renomureza
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently the landing page width is broken when opened on small screens and when pressing the dark mode toggle.

fixed #1572

What is the new behavior?

  • The width is consistent, not broken, and does not change when pressing the dark mode toggle button.
  • The logo (used in the hero) is more precise and sharp.

Other information

On 375px screen:

image

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1b70818

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

atk
atk suggested changes Aug 1, 2024
View reviewed changes
docs/components/icons/solidstart-logo.tsx Show resolved Hide resolved
docs/components/sections/hero.tsx Outdated Show resolved Hide resolved
@ryansolid
Copy link
Member

Thank you

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 12, 2024

commit: 1b70818

pnpm add https://pkg.pr.new/@solidjs/start@1592

Open in Stackblitz

More templates

@ryansolid ryansolid merged commit 516eb82 into solidjs:main Aug 12, 2024
3 checks passed
@renomureza renomureza deleted the update-landing-page branch August 13, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atk atk atk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug?]: Landing page is broken on small screen size
3 participants
@renomureza @ryansolid @atk